Pārlūkot izejas kodu

drm/msm: fix HZ dependency of timeout

The timeout is passed as a constant which makes it HZ dependent because
jiffies are expected so it should be converted to jiffies. The actual
value is not clear from the code - my best guess is that this should be
300 milliseconds given that other timeouts are in milliseconds based on
looking at other drm drivers (e.g. exynos_drm_dsi.c:356 300ms,
tegra/dpaux.c:188 250ms) - this needs to be confirmed by someone who
knows the details of the driver.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Rob Clark <robdclark@gmail.com>
Nicholas Mc Guire 10 gadi atpakaļ
vecāks
revīzija
84c3b87b8b
1 mainītis faili ar 2 papildinājumiem un 1 dzēšanām
  1. 2 1
      drivers/gpu/drm/msm/edp/edp_aux.c

+ 2 - 1
drivers/gpu/drm/msm/edp/edp_aux.c

@@ -148,7 +148,8 @@ ssize_t edp_aux_transfer(struct drm_dp_aux *drm_aux, struct drm_dp_aux_msg *msg)
 		goto unlock_exit;
 		goto unlock_exit;
 
 
 	DBG("wait_for_completion");
 	DBG("wait_for_completion");
-	time_left = wait_for_completion_timeout(&aux->msg_comp, 300);
+	time_left = wait_for_completion_timeout(&aux->msg_comp,
+						msecs_to_jiffies(300));
 	if (!time_left) {
 	if (!time_left) {
 		/*
 		/*
 		 * Clear GO and reset AUX channel
 		 * Clear GO and reset AUX channel