Explorar o código

iommu/tegra-smmu: Fix return value check in tegra_smmu_group_get()

In case of error, the function iommu_group_alloc() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().

Fixes: 7f4c9176f760 ("iommu/tegra: Allow devices to be grouped")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Wei Yongjun %!s(int64=7) %!d(string=hai) anos
pai
achega
83476bfaf6
Modificáronse 1 ficheiros con 1 adicións e 1 borrados
  1. 1 1
      drivers/iommu/tegra-smmu.c

+ 1 - 1
drivers/iommu/tegra-smmu.c

@@ -832,7 +832,7 @@ static struct iommu_group *tegra_smmu_group_get(struct tegra_smmu *smmu,
 	group->soc = soc;
 	group->soc = soc;
 
 
 	group->group = iommu_group_alloc();
 	group->group = iommu_group_alloc();
-	if (!group->group) {
+	if (IS_ERR(group->group)) {
 		devm_kfree(smmu->dev, group);
 		devm_kfree(smmu->dev, group);
 		mutex_unlock(&smmu->lock);
 		mutex_unlock(&smmu->lock);
 		return NULL;
 		return NULL;