Browse Source

IB/rxe: Fix up rxe_qp_cleanup()

Replace sk_dst_get()/dst_release() in rxe_qp_cleanup() with sk_dst_reset().
sk_dst_get() takes a new reference on dst, so the dst_release() doesn't
actually release the original reference, which was the design intent.

Fixes: 4ed6ad1eb30e ("IB/rxe: Cache dst in QP instead of getting it...")
Signed-off-by: Andrew Boyer <andrew.boyer@dell.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Andrew Boyer 8 years ago
parent
commit
825a51a4af
1 changed files with 2 additions and 7 deletions
  1. 2 7
      drivers/infiniband/sw/rxe/rxe_qp.c

+ 2 - 7
drivers/infiniband/sw/rxe/rxe_qp.c

@@ -851,13 +851,8 @@ void rxe_qp_cleanup(struct rxe_pool_entry *arg)
 		qp->resp.mr = NULL;
 		qp->resp.mr = NULL;
 	}
 	}
 
 
-	if (qp_type(qp) == IB_QPT_RC) {
-		struct dst_entry *dst = NULL;
-
-		dst = sk_dst_get(qp->sk->sk);
-		if (dst)
-			dst_release(dst);
-	}
+	if (qp_type(qp) == IB_QPT_RC)
+		sk_dst_reset(qp->sk->sk);
 
 
 	free_rd_atomic_resources(qp);
 	free_rd_atomic_resources(qp);