浏览代码

rtc: tx4939: clean up tx4939_rtc_nvram_read()/tx4939_rtc_nvram_write()

The change removes redundant sysfs binary file boundary checks, since
this task is already done on caller side in fs/sysfs/file.c

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Vladimir Zapolskiy 10 年之前
父节点
当前提交
824625d392
共有 1 个文件被更改,包括 2 次插入4 次删除
  1. 2 4
      drivers/rtc/rtc-tx4939.c

+ 2 - 4
drivers/rtc/rtc-tx4939.c

@@ -199,8 +199,7 @@ static ssize_t tx4939_rtc_nvram_read(struct file *filp, struct kobject *kobj,
 	ssize_t count;
 	ssize_t count;
 
 
 	spin_lock_irq(&pdata->lock);
 	spin_lock_irq(&pdata->lock);
-	for (count = 0; size > 0 && pos < TX4939_RTC_REG_RAMSIZE;
-	     count++, size--) {
+	for (count = 0; count < size; count++) {
 		__raw_writel(pos++, &rtcreg->adr);
 		__raw_writel(pos++, &rtcreg->adr);
 		*buf++ = __raw_readl(&rtcreg->dat);
 		*buf++ = __raw_readl(&rtcreg->dat);
 	}
 	}
@@ -218,8 +217,7 @@ static ssize_t tx4939_rtc_nvram_write(struct file *filp, struct kobject *kobj,
 	ssize_t count;
 	ssize_t count;
 
 
 	spin_lock_irq(&pdata->lock);
 	spin_lock_irq(&pdata->lock);
-	for (count = 0; size > 0 && pos < TX4939_RTC_REG_RAMSIZE;
-	     count++, size--) {
+	for (count = 0; count < size; count++) {
 		__raw_writel(pos++, &rtcreg->adr);
 		__raw_writel(pos++, &rtcreg->adr);
 		__raw_writel(*buf++, &rtcreg->dat);
 		__raw_writel(*buf++, &rtcreg->dat);
 	}
 	}