瀏覽代碼

usbnet: qmi_wwan: comments on suspend failure

If suspend callback fails in system sleep context, usb core will
ignore the failure and let system sleep go ahead further, so
this patch comments on the case and requires that both
usbnet_suspend() and subdriver->suspend() MUST return 0 in
system sleep context.

Acked-by: David S. Miller <davem@davemloft.net>
Acked-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ming Lei 12 年之前
父節點
當前提交
81b50be036
共有 1 個文件被更改,包括 5 次插入0 次删除
  1. 5 0
      drivers/net/usb/qmi_wwan.c

+ 5 - 0
drivers/net/usb/qmi_wwan.c

@@ -271,6 +271,11 @@ static int qmi_wwan_suspend(struct usb_interface *intf, pm_message_t message)
 	struct qmi_wwan_state *info = (void *)&dev->data;
 	struct qmi_wwan_state *info = (void *)&dev->data;
 	int ret;
 	int ret;
 
 
+	/*
+	 * Both usbnet_suspend() and subdriver->suspend() MUST return 0
+	 * in system sleep context, otherwise, the resume callback has
+	 * to recover device from previous suspend failure.
+	 */
 	ret = usbnet_suspend(intf, message);
 	ret = usbnet_suspend(intf, message);
 	if (ret < 0)
 	if (ret < 0)
 		goto err;
 		goto err;