Преглед изворни кода

misc: mic: double free on ioctl error path

This function only has one caller.  Freeing "vdev" here leads to a use
after free bug.  There are several other error paths in this function
but this is the only one which frees "vdev".  It looks like the kfree()
can be safely removed.

Fixes: 61e9c905df78 ("misc: mic: Enable VOP host side functionality")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter пре 8 година
родитељ
комит
816c9311f1
1 измењених фајлова са 0 додато и 1 уклоњено
  1. 0 1
      drivers/misc/mic/vop/vop_vringh.c

+ 0 - 1
drivers/misc/mic/vop/vop_vringh.c

@@ -292,7 +292,6 @@ static int vop_virtio_add_device(struct vop_vdev *vdev,
 	if (ret) {
 		dev_err(vop_dev(vdev), "%s %d err %d\n",
 			__func__, __LINE__, ret);
-		kfree(vdev);
 		return ret;
 	}