Browse Source

omapfb: Return error code when applying overlay settings fails

the check of the return code is missing, user space does not get notified
about the error condition:

omapdss OVERLAY error: overlay 2 horizontally not inside the display area (403 + 800 >= 800)
omapdss APPLY error: failed to apply settings: illegal configuration.

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Peter Meerwald 10 years ago
parent
commit
811fbb1f58
1 changed files with 5 additions and 2 deletions
  1. 5 2
      drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c

+ 5 - 2
drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c

@@ -137,8 +137,11 @@ static int omapfb_setup_plane(struct fb_info *fbi, struct omapfb_plane_info *pi)
 			goto undo;
 	}
 
-	if (ovl->manager)
-		ovl->manager->apply(ovl->manager);
+	if (ovl->manager) {
+		r = ovl->manager->apply(ovl->manager);
+		if (r)
+			goto undo;
+	}
 
 	if (pi->enabled) {
 		r = ovl->enable(ovl);