Browse Source

OMAPDSS: pll: NULL dereference in error handling

The regulator_disable() doesn't accept NULL pointers.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Dan Carpenter 10 years ago
parent
commit
811174f45f
1 changed files with 2 additions and 1 deletions
  1. 2 1
      drivers/video/fbdev/omap2/dss/pll.c

+ 2 - 1
drivers/video/fbdev/omap2/dss/pll.c

@@ -97,7 +97,8 @@ int dss_pll_enable(struct dss_pll *pll)
 	return 0;
 
 err_enable:
-	regulator_disable(pll->regulator);
+	if (pll->regulator)
+		regulator_disable(pll->regulator);
 err_reg:
 	clk_disable_unprepare(pll->clkin);
 	return r;