Browse Source

ext4: fix warning message in ext4_enable_quotas()

Output the warning message before we clobber type and be -1 all the time.
The error message would now be

[    1.519791] EXT4-fs warning (device vdb): ext4_enable_quotas:5402:
Failed to enable quota tracking (type=0, err=-3). Please run e2fsck to fix.

Signed-off-by: Junichi Uekawa <uekawa@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Junichi Uekawa 7 years ago
parent
commit
7f144fd046
1 changed files with 3 additions and 3 deletions
  1. 3 3
      fs/ext4/super.c

+ 3 - 3
fs/ext4/super.c

@@ -5686,13 +5686,13 @@ static int ext4_enable_quotas(struct super_block *sb)
 				DQUOT_USAGE_ENABLED |
 				DQUOT_USAGE_ENABLED |
 				(quota_mopt[type] ? DQUOT_LIMITS_ENABLED : 0));
 				(quota_mopt[type] ? DQUOT_LIMITS_ENABLED : 0));
 			if (err) {
 			if (err) {
-				for (type--; type >= 0; type--)
-					dquot_quota_off(sb, type);
-
 				ext4_warning(sb,
 				ext4_warning(sb,
 					"Failed to enable quota tracking "
 					"Failed to enable quota tracking "
 					"(type=%d, err=%d). Please run "
 					"(type=%d, err=%d). Please run "
 					"e2fsck to fix.", type, err);
 					"e2fsck to fix.", type, err);
+				for (type--; type >= 0; type--)
+					dquot_quota_off(sb, type);
+
 				return err;
 				return err;
 			}
 			}
 		}
 		}