浏览代码

staging: iio: fix ad7606_spi regression

As pointed out by Geert Uytterhoeven, the patch was incorrect
and breaks the driver, which was fortunately pointed out by
this gcc warning:

drivers/staging/iio/adc/ad7606_spi.c: In function ‘ad7606_spi_read_block’:
drivers/staging/iio/adc/ad7606_spi.c:34: warning: ‘data’ is used uninitialized in this function

The effect of the patch is that the data is copied into
a random memory location (from the uninitialized pointer)
instead of being byteswapped in place.

This adds the initialization for the 'data' variable back
to restore the original behavior.

Cc: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Fixes: 87787e5ef727 ("Staging: iio: Fix sparse endian warning")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Arnd Bergmann 9 年之前
父节点
当前提交
7e982555d8
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/staging/iio/adc/ad7606_spi.c

+ 1 - 1
drivers/staging/iio/adc/ad7606_spi.c

@@ -21,7 +21,7 @@ static int ad7606_spi_read_block(struct device *dev,
 {
 {
 	struct spi_device *spi = to_spi_device(dev);
 	struct spi_device *spi = to_spi_device(dev);
 	int i, ret;
 	int i, ret;
-	unsigned short *data;
+	unsigned short *data = buf;
 	__be16 *bdata = buf;
 	__be16 *bdata = buf;
 
 
 	ret = spi_read(spi, buf, count * 2);
 	ret = spi_read(spi, buf, count * 2);