Эх сурвалжийг харах

ethernet: marvell: remove unnecessary check

devm_ioremap_resource checks platform_get_resource() return value.
We can remove the duplicate check here.

Signed-off-by: Varka Bhadram <varkab@cdac.in>
Signed-off-by: David S. Miller <davem@davemloft.net>
Varka Bhadram 10 жил өмнө
parent
commit
7e5ae24aa0

+ 2 - 4
drivers/net/ethernet/marvell/pxa168_eth.c

@@ -1450,16 +1450,14 @@ static int pxa168_eth_probe(struct platform_device *pdev)
 	pep = netdev_priv(dev);
 	pep = netdev_priv(dev);
 	pep->dev = dev;
 	pep->dev = dev;
 	pep->clk = clk;
 	pep->clk = clk;
+
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (res == NULL) {
-		err = -ENODEV;
-		goto err_netdev;
-	}
 	pep->base = devm_ioremap_resource(&pdev->dev, res);
 	pep->base = devm_ioremap_resource(&pdev->dev, res);
 	if (IS_ERR(pep->base)) {
 	if (IS_ERR(pep->base)) {
 		err = -ENOMEM;
 		err = -ENOMEM;
 		goto err_netdev;
 		goto err_netdev;
 	}
 	}
+
 	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
 	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
 	BUG_ON(!res);
 	BUG_ON(!res);
 	dev->irq = res->start;
 	dev->irq = res->start;