Browse Source

fbdev: omap2: remove potential format string leak

Since kobject_init_and_add takes a format string, make sure that the
passed in name cannot be accidentally parsed.

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Kees Cook 10 years ago
parent
commit
7e46cd705f
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/video/fbdev/omap2/dss/display-sysfs.c

+ 1 - 1
drivers/video/fbdev/omap2/dss/display-sysfs.c

@@ -324,7 +324,7 @@ int display_init_sysfs(struct platform_device *pdev)
 
 	for_each_dss_dev(dssdev) {
 		r = kobject_init_and_add(&dssdev->kobj, &display_ktype,
-			&pdev->dev.kobj, dssdev->alias);
+			&pdev->dev.kobj, "%s", dssdev->alias);
 		if (r) {
 			DSSERR("failed to create sysfs files\n");
 			omap_dss_put_device(dssdev);