瀏覽代碼

gpio: adp5588: Use devm_gpiochip_add_data() for gpio registration

Use devm_gpiochip_add_data() for GPIO registration and remove the
call for gpiochip_remove() from remove callback.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Laxman Dewangan 9 年之前
父節點
當前提交
7c263fe025
共有 1 個文件被更改,包括 1 次插入3 次删除
  1. 1 3
      drivers/gpio/gpio-adp5588.c

+ 1 - 3
drivers/gpio/gpio-adp5588.c

@@ -414,7 +414,7 @@ static int adp5588_gpio_probe(struct i2c_client *client,
 		}
 		}
 	}
 	}
 
 
-	ret = gpiochip_add_data(&dev->gpio_chip, dev);
+	ret = devm_gpiochip_add_data(&client->dev, &dev->gpio_chip, dev);
 	if (ret)
 	if (ret)
 		goto err_irq;
 		goto err_irq;
 
 
@@ -457,8 +457,6 @@ static int adp5588_gpio_remove(struct i2c_client *client)
 	if (dev->irq_base)
 	if (dev->irq_base)
 		free_irq(dev->client->irq, dev);
 		free_irq(dev->client->irq, dev);
 
 
-	gpiochip_remove(&dev->gpio_chip);
-
 	return 0;
 	return 0;
 }
 }