Browse Source

crypto: amcc - check return value of sg_nents_for_len

The sg_nents_for_len() function could fail, this patch add a check for
its return value.

Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
LABBE Corentin 10 years ago
parent
commit
7aff7d0abc
1 changed files with 4 additions and 0 deletions
  1. 4 0
      drivers/crypto/amcc/crypto4xx_core.c

+ 4 - 0
drivers/crypto/amcc/crypto4xx_core.c

@@ -781,6 +781,10 @@ u32 crypto4xx_build_pd(struct crypto_async_request *req,
 
 
 	/* figure how many gd is needed */
 	/* figure how many gd is needed */
 	num_gd = sg_nents_for_len(src, datalen);
 	num_gd = sg_nents_for_len(src, datalen);
+	if ((int)num_gd < 0) {
+		dev_err(dev->core_dev->device, "Invalid number of src SG.\n");
+		return -EINVAL;
+	}
 	if (num_gd == 1)
 	if (num_gd == 1)
 		num_gd = 0;
 		num_gd = 0;