Przeglądaj źródła

iio: kfifo: Remove unused argument in iio_kfifo_allocate

indio_dev was unused in function body plus some small style fix - add new
lines after "if(sth) return sth" and before the last return statement.

The argument was removed also in its client.

Signed-off-by: Karol Wrona <k.wrona@samsung.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Karol Wrona 11 lat temu
rodzic
commit
7ab374a053

+ 1 - 1
drivers/iio/adc/ti_am335x_adc.c

@@ -250,7 +250,7 @@ static int tiadc_iio_buffered_hardware_setup(struct iio_dev *indio_dev,
 	struct iio_buffer *buffer;
 	struct iio_buffer *buffer;
 	int ret;
 	int ret;
 
 
-	buffer = iio_kfifo_allocate(indio_dev);
+	buffer = iio_kfifo_allocate();
 	if (!buffer)
 	if (!buffer)
 		return -ENOMEM;
 		return -ENOMEM;
 
 

+ 1 - 1
drivers/iio/industrialio-triggered-buffer.c

@@ -49,7 +49,7 @@ int iio_triggered_buffer_setup(struct iio_dev *indio_dev,
 	struct iio_buffer *buffer;
 	struct iio_buffer *buffer;
 	int ret;
 	int ret;
 
 
-	buffer = iio_kfifo_allocate(indio_dev);
+	buffer = iio_kfifo_allocate();
 	if (!buffer) {
 	if (!buffer) {
 		ret = -ENOMEM;
 		ret = -ENOMEM;
 		goto error_ret;
 		goto error_ret;

+ 4 - 2
drivers/iio/kfifo_buf.c

@@ -140,18 +140,20 @@ static const struct iio_buffer_access_funcs kfifo_access_funcs = {
 	.release = &iio_kfifo_buffer_release,
 	.release = &iio_kfifo_buffer_release,
 };
 };
 
 
-struct iio_buffer *iio_kfifo_allocate(struct iio_dev *indio_dev)
+struct iio_buffer *iio_kfifo_allocate(void)
 {
 {
 	struct iio_kfifo *kf;
 	struct iio_kfifo *kf;
 
 
-	kf = kzalloc(sizeof *kf, GFP_KERNEL);
+	kf = kzalloc(sizeof(*kf), GFP_KERNEL);
 	if (!kf)
 	if (!kf)
 		return NULL;
 		return NULL;
+
 	kf->update_needed = true;
 	kf->update_needed = true;
 	iio_buffer_init(&kf->buffer);
 	iio_buffer_init(&kf->buffer);
 	kf->buffer.access = &kfifo_access_funcs;
 	kf->buffer.access = &kfifo_access_funcs;
 	kf->buffer.length = 2;
 	kf->buffer.length = 2;
 	mutex_init(&kf->user_lock);
 	mutex_init(&kf->user_lock);
+
 	return &kf->buffer;
 	return &kf->buffer;
 }
 }
 EXPORT_SYMBOL(iio_kfifo_allocate);
 EXPORT_SYMBOL(iio_kfifo_allocate);

+ 1 - 1
drivers/staging/iio/accel/lis3l02dq_ring.c

@@ -393,7 +393,7 @@ int lis3l02dq_configure_buffer(struct iio_dev *indio_dev)
 	int ret;
 	int ret;
 	struct iio_buffer *buffer;
 	struct iio_buffer *buffer;
 
 
-	buffer = iio_kfifo_allocate(indio_dev);
+	buffer = iio_kfifo_allocate();
 	if (!buffer)
 	if (!buffer)
 		return -ENOMEM;
 		return -ENOMEM;
 
 

+ 1 - 1
drivers/staging/iio/iio_simple_dummy_buffer.c

@@ -121,7 +121,7 @@ int iio_simple_dummy_configure_buffer(struct iio_dev *indio_dev)
 	struct iio_buffer *buffer;
 	struct iio_buffer *buffer;
 
 
 	/* Allocate a buffer to use - here a kfifo */
 	/* Allocate a buffer to use - here a kfifo */
-	buffer = iio_kfifo_allocate(indio_dev);
+	buffer = iio_kfifo_allocate();
 	if (buffer == NULL) {
 	if (buffer == NULL) {
 		ret = -ENOMEM;
 		ret = -ENOMEM;
 		goto error_ret;
 		goto error_ret;

+ 1 - 1
drivers/staging/iio/impedance-analyzer/ad5933.c

@@ -626,7 +626,7 @@ static int ad5933_register_ring_funcs_and_init(struct iio_dev *indio_dev)
 {
 {
 	struct iio_buffer *buffer;
 	struct iio_buffer *buffer;
 
 
-	buffer = iio_kfifo_allocate(indio_dev);
+	buffer = iio_kfifo_allocate();
 	if (!buffer)
 	if (!buffer)
 		return -ENOMEM;
 		return -ENOMEM;
 
 

+ 1 - 1
drivers/staging/iio/meter/ade7758_ring.c

@@ -119,7 +119,7 @@ int ade7758_configure_ring(struct iio_dev *indio_dev)
 	struct iio_buffer *buffer;
 	struct iio_buffer *buffer;
 	int ret = 0;
 	int ret = 0;
 
 
-	buffer = iio_kfifo_allocate(indio_dev);
+	buffer = iio_kfifo_allocate();
 	if (!buffer) {
 	if (!buffer) {
 		ret = -ENOMEM;
 		ret = -ENOMEM;
 		return ret;
 		return ret;

+ 1 - 1
include/linux/iio/kfifo_buf.h

@@ -5,7 +5,7 @@
 #include <linux/iio/iio.h>
 #include <linux/iio/iio.h>
 #include <linux/iio/buffer.h>
 #include <linux/iio/buffer.h>
 
 
-struct iio_buffer *iio_kfifo_allocate(struct iio_dev *indio_dev);
+struct iio_buffer *iio_kfifo_allocate(void);
 void iio_kfifo_free(struct iio_buffer *r);
 void iio_kfifo_free(struct iio_buffer *r);
 
 
 #endif
 #endif