Browse Source

cpuset: initialize effective masks when clone_children is enabled

If clone_children is enabled, effective masks won't be initialized
due to the bug:

  # mount -t cgroup -o cpuset xxx /mnt
  # echo 1 > cgroup.clone_children
  # mkdir /mnt/tmp
  # cat /mnt/tmp/
  # cat cpuset.effective_cpus

  # cat cpuset.cpus
  0-15

And then this cpuset won't constrain the tasks in it.

Either the bug or the fix has no effect on unified hierarchy, as
there's no clone_chidren flag there any more.

Reported-by: Christian Brauner <christianvanbrauner@gmail.com>
Reported-by: Serge Hallyn <serge.hallyn@ubuntu.com>
Cc: <stable@vger.kernel.org> # 3.17+
Signed-off-by: Zefan Li <lizefan@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Tested-by: Serge Hallyn <serge.hallyn@canonical.com>
Zefan Li 10 years ago
parent
commit
790317e1b2
1 changed files with 2 additions and 0 deletions
  1. 2 0
      kernel/cpuset.c

+ 2 - 0
kernel/cpuset.c

@@ -1979,7 +1979,9 @@ static int cpuset_css_online(struct cgroup_subsys_state *css)
 
 
 	spin_lock_irq(&callback_lock);
 	spin_lock_irq(&callback_lock);
 	cs->mems_allowed = parent->mems_allowed;
 	cs->mems_allowed = parent->mems_allowed;
+	cs->effective_mems = parent->mems_allowed;
 	cpumask_copy(cs->cpus_allowed, parent->cpus_allowed);
 	cpumask_copy(cs->cpus_allowed, parent->cpus_allowed);
+	cpumask_copy(cs->effective_cpus, parent->cpus_allowed);
 	spin_unlock_irq(&callback_lock);
 	spin_unlock_irq(&callback_lock);
 out_unlock:
 out_unlock:
 	mutex_unlock(&cpuset_mutex);
 	mutex_unlock(&cpuset_mutex);