Эх сурвалжийг харах

xen/pvcalls: remove redundant check for irq >= 0

This is a moot point, but irq is always less than zero at the label
out_error, so the check for irq >= 0 is redundant and can be removed.

Detected by CoverityScan, CID#1460371 ("Logically dead code")

Fixes: cb1c7d9bbc87 ("xen/pvcalls: implement connect command")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Colin Ian King 7 жил өмнө
parent
commit
773aaadcd4

+ 1 - 3
drivers/xen/pvcalls-front.c

@@ -351,9 +351,7 @@ static int create_active(struct sock_mapping *map, int *evtchn)
 	return 0;
 	return 0;
 
 
 out_error:
 out_error:
-	if (irq >= 0)
-		unbind_from_irqhandler(irq, map);
-	else if (*evtchn >= 0)
+	if (*evtchn >= 0)
 		xenbus_free_evtchn(pvcalls_front_dev, *evtchn);
 		xenbus_free_evtchn(pvcalls_front_dev, *evtchn);
 	kfree(map->active.data.in);
 	kfree(map->active.data.in);
 	kfree(map->active.ring);
 	kfree(map->active.ring);