Browse Source

i40e: hush little warnings

These messages seem big and scary, but they're really not. The driver
can fully recover from any of these. The overflow error in particular
can happen when enabling a bunch of VFs and the VF driver is not
blacklisted.

Since these messages are really for debugging purposes, reclassify
them as such.

Change-ID: I628d0f5e135e7063450ba05393a50b7af23aa6d7
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Mitch Williams 9 years ago
parent
commit
75eb73c127
1 changed files with 12 additions and 6 deletions
  1. 12 6
      drivers/net/ethernet/intel/i40e/i40e_main.c

+ 12 - 6
drivers/net/ethernet/intel/i40e/i40e_main.c

@@ -6219,15 +6219,18 @@ static void i40e_clean_adminq_subtask(struct i40e_pf *pf)
 	val = rd32(&pf->hw, pf->hw.aq.arq.len);
 	val = rd32(&pf->hw, pf->hw.aq.arq.len);
 	oldval = val;
 	oldval = val;
 	if (val & I40E_PF_ARQLEN_ARQVFE_MASK) {
 	if (val & I40E_PF_ARQLEN_ARQVFE_MASK) {
-		dev_info(&pf->pdev->dev, "ARQ VF Error detected\n");
+		if (hw->debug_mask & I40E_DEBUG_AQ)
+			dev_info(&pf->pdev->dev, "ARQ VF Error detected\n");
 		val &= ~I40E_PF_ARQLEN_ARQVFE_MASK;
 		val &= ~I40E_PF_ARQLEN_ARQVFE_MASK;
 	}
 	}
 	if (val & I40E_PF_ARQLEN_ARQOVFL_MASK) {
 	if (val & I40E_PF_ARQLEN_ARQOVFL_MASK) {
-		dev_info(&pf->pdev->dev, "ARQ Overflow Error detected\n");
+		if (hw->debug_mask & I40E_DEBUG_AQ)
+			dev_info(&pf->pdev->dev, "ARQ Overflow Error detected\n");
 		val &= ~I40E_PF_ARQLEN_ARQOVFL_MASK;
 		val &= ~I40E_PF_ARQLEN_ARQOVFL_MASK;
 	}
 	}
 	if (val & I40E_PF_ARQLEN_ARQCRIT_MASK) {
 	if (val & I40E_PF_ARQLEN_ARQCRIT_MASK) {
-		dev_info(&pf->pdev->dev, "ARQ Critical Error detected\n");
+		if (hw->debug_mask & I40E_DEBUG_AQ)
+			dev_info(&pf->pdev->dev, "ARQ Critical Error detected\n");
 		val &= ~I40E_PF_ARQLEN_ARQCRIT_MASK;
 		val &= ~I40E_PF_ARQLEN_ARQCRIT_MASK;
 	}
 	}
 	if (oldval != val)
 	if (oldval != val)
@@ -6236,15 +6239,18 @@ static void i40e_clean_adminq_subtask(struct i40e_pf *pf)
 	val = rd32(&pf->hw, pf->hw.aq.asq.len);
 	val = rd32(&pf->hw, pf->hw.aq.asq.len);
 	oldval = val;
 	oldval = val;
 	if (val & I40E_PF_ATQLEN_ATQVFE_MASK) {
 	if (val & I40E_PF_ATQLEN_ATQVFE_MASK) {
-		dev_info(&pf->pdev->dev, "ASQ VF Error detected\n");
+		if (pf->hw.debug_mask & I40E_DEBUG_AQ)
+			dev_info(&pf->pdev->dev, "ASQ VF Error detected\n");
 		val &= ~I40E_PF_ATQLEN_ATQVFE_MASK;
 		val &= ~I40E_PF_ATQLEN_ATQVFE_MASK;
 	}
 	}
 	if (val & I40E_PF_ATQLEN_ATQOVFL_MASK) {
 	if (val & I40E_PF_ATQLEN_ATQOVFL_MASK) {
-		dev_info(&pf->pdev->dev, "ASQ Overflow Error detected\n");
+		if (pf->hw.debug_mask & I40E_DEBUG_AQ)
+			dev_info(&pf->pdev->dev, "ASQ Overflow Error detected\n");
 		val &= ~I40E_PF_ATQLEN_ATQOVFL_MASK;
 		val &= ~I40E_PF_ATQLEN_ATQOVFL_MASK;
 	}
 	}
 	if (val & I40E_PF_ATQLEN_ATQCRIT_MASK) {
 	if (val & I40E_PF_ATQLEN_ATQCRIT_MASK) {
-		dev_info(&pf->pdev->dev, "ASQ Critical Error detected\n");
+		if (pf->hw.debug_mask & I40E_DEBUG_AQ)
+			dev_info(&pf->pdev->dev, "ASQ Critical Error detected\n");
 		val &= ~I40E_PF_ATQLEN_ATQCRIT_MASK;
 		val &= ~I40E_PF_ATQLEN_ATQCRIT_MASK;
 	}
 	}
 	if (oldval != val)
 	if (oldval != val)