Browse Source

Smack: correct final mmap check comparison

The mmap policy enforcement checks the access of the
SMACK64MMAP subject against the current subject incorrectly.
The check as written works correctly only if the access
rules involved have the same access. This is the common
case, so initial testing did not find a problem.

Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
Casey Schaufler 14 năm trước cách đây
mục cha
commit
75a25637bf
1 tập tin đã thay đổi với 1 bổ sung1 xóa
  1. 1 1
      security/smack/smack_lsm.c

+ 1 - 1
security/smack/smack_lsm.c

@@ -1218,7 +1218,7 @@ static int smack_file_mmap(struct file *file,
 		 * not available to a SMACK64MMAP subject
 		 * deny access.
 		 */
-		if ((may | mmay) != may) {
+		if ((may | mmay) != mmay) {
 			rc = -EACCES;
 			break;
 		}