Browse Source

usb: chipidea: msm: Fix return value check in ci_hdrc_msm_probe()

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: 2fc305be364e ("usb: chipidea: msm: Mux over secondary phy at the
right time")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Stephen Boyd <stephen.boyd@linaro.org>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
Wei Yongjun 8 years ago
parent
commit
753dfd2361
1 changed files with 2 additions and 2 deletions
  1. 2 2
      drivers/usb/chipidea/ci_hdrc_msm.c

+ 2 - 2
drivers/usb/chipidea/ci_hdrc_msm.c

@@ -218,8 +218,8 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
 	ci->base = devm_ioremap_resource(&pdev->dev, res);
-	if (!ci->base)
-		return -ENOMEM;
+	if (IS_ERR(ci->base))
+		return PTR_ERR(ci->base);
 
 	ci->rcdev.owner = THIS_MODULE;
 	ci->rcdev.ops = &ci_hdrc_msm_reset_ops;