Browse Source

bnxt_en: VF/NPAR should return -EOPNOTSUPP for unsupported ethtool ops.

Returning 0 for doing nothing is confusing to the user.

Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Michael Chan 9 years ago
parent
commit
75362a3fd4
1 changed files with 2 additions and 2 deletions
  1. 2 2
      drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

+ 2 - 2
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

@@ -961,7 +961,7 @@ static int bnxt_set_pauseparam(struct net_device *dev,
 	struct bnxt_link_info *link_info = &bp->link_info;
 	struct bnxt_link_info *link_info = &bp->link_info;
 
 
 	if (!BNXT_SINGLE_PF(bp))
 	if (!BNXT_SINGLE_PF(bp))
-		return rc;
+		return -EOPNOTSUPP;
 
 
 	if (epause->autoneg) {
 	if (epause->autoneg) {
 		if (!(link_info->autoneg & BNXT_AUTONEG_SPEED))
 		if (!(link_info->autoneg & BNXT_AUTONEG_SPEED))
@@ -1483,7 +1483,7 @@ static int bnxt_set_eee(struct net_device *dev, struct ethtool_eee *edata)
 	int rc = 0;
 	int rc = 0;
 
 
 	if (!BNXT_SINGLE_PF(bp))
 	if (!BNXT_SINGLE_PF(bp))
-		return 0;
+		return -EOPNOTSUPP;
 
 
 	if (!(bp->flags & BNXT_FLAG_EEE_CAP))
 	if (!(bp->flags & BNXT_FLAG_EEE_CAP))
 		return -EOPNOTSUPP;
 		return -EOPNOTSUPP;