Browse Source

net: hns3: Fixes the wrong IS_ERR check on the returned phydev value

This patch removes the wrong check being done for the phy device being
returned by the mdiobus_get_phy() function. This function never returns
the error pointers.

Fixes: 256727da7395 ("net: hns3: Add MDIO support to HNS3 Ethernet
Driver for hip08 SoC")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Salil Mehta 8 years ago
parent
commit
752b06946c
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c

+ 1 - 1
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c

@@ -150,7 +150,7 @@ int hclge_mac_mdio_config(struct hclge_dev *hdev)
 	}
 	}
 
 
 	phydev = mdiobus_get_phy(mdio_bus, mac->phy_addr);
 	phydev = mdiobus_get_phy(mdio_bus, mac->phy_addr);
-	if (!phydev || IS_ERR(phydev)) {
+	if (!phydev) {
 		dev_err(mdio_bus->parent, "Failed to get phy device\n");
 		dev_err(mdio_bus->parent, "Failed to get phy device\n");
 		mdiobus_unregister(mdio_bus);
 		mdiobus_unregister(mdio_bus);
 		return -EIO;
 		return -EIO;