Browse Source

bgmac: Fix reversed test of build_skb() return value.

Fixes: f1640c3ddeec ("bgmac: fix a missing check for build_skb")
Signed-off-by: David S. Miller <davem@davemloft.net>
David S. Miller 9 years ago
parent
commit
750afbf8ee
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/net/ethernet/broadcom/bgmac.c

+ 1 - 1
drivers/net/ethernet/broadcom/bgmac.c

@@ -466,7 +466,7 @@ static int bgmac_dma_rx_read(struct bgmac *bgmac, struct bgmac_dma_ring *ring,
 			len -= ETH_FCS_LEN;
 			len -= ETH_FCS_LEN;
 
 
 			skb = build_skb(buf, BGMAC_RX_ALLOC_SIZE);
 			skb = build_skb(buf, BGMAC_RX_ALLOC_SIZE);
-			if (unlikely(skb)) {
+			if (unlikely(!skb)) {
 				bgmac_err(bgmac, "build_skb failed\n");
 				bgmac_err(bgmac, "build_skb failed\n");
 				put_page(virt_to_head_page(buf));
 				put_page(virt_to_head_page(buf));
 				break;
 				break;