Home Explore Help
Sign In
GfA
/
linux_kernel
5
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

base: memory: fix soft/hard_offline_page permissions

those two sysfs files don't have a 'show' method,
so they shouldn't have a read permission. Thanks
to Greg Kroah-Hartman for actually looking into
the source code and figuring out we had a real bug
with these two files.

Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Felipe Balbi 12 years ago
parent
d72cca1eee
commit
74fef7a8fd
1 changed files with 2 additions and 2 deletions
Unified View Show Diff Stats
  1. 2 2
      drivers/base/memory.c

+ 2 - 2
drivers/base/memory.c
View File 

@@ -494,8 +494,8 @@ store_hard_offline_page(struct device *dev,
 
 	return ret ? ret : count;
 
 	return ret ? ret : count;
 
 }
 
 }
 
 
 
-static DEVICE_ATTR(soft_offline_page, 0644, NULL, store_soft_offline_page);
 
-static DEVICE_ATTR(hard_offline_page, 0644, NULL, store_hard_offline_page);
 
+static DEVICE_ATTR(soft_offline_page, S_IWUSR, NULL, store_soft_offline_page);
 
+static DEVICE_ATTR(hard_offline_page, S_IWUSR, NULL, store_hard_offline_page);
 
 
 
 static __init int memory_fail_init(void)
 
 static __init int memory_fail_init(void)
 
 {
 
 {