Prechádzať zdrojové kódy

USB: serial: garmin_gps: fix memory leak on probe errors

Make sure to free the port private data before returning after a failed
probe attempt.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable <stable@vger.kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Johan Hovold 7 rokov pred
rodič
commit
74d471b598
1 zmenil súbory, kde vykonal 6 pridanie a 0 odobranie
  1. 6 0
      drivers/usb/serial/garmin_gps.c

+ 6 - 0
drivers/usb/serial/garmin_gps.c

@@ -1411,6 +1411,12 @@ static int garmin_port_probe(struct usb_serial_port *port)
 	usb_set_serial_port_data(port, garmin_data_p);
 	usb_set_serial_port_data(port, garmin_data_p);
 
 
 	status = garmin_init_session(port);
 	status = garmin_init_session(port);
+	if (status)
+		goto err_free;
+
+	return 0;
+err_free:
+	kfree(garmin_data_p);
 
 
 	return status;
 	return status;
 }
 }