Просмотр исходного кода

drm/amd/display: checking for NULL instead of IS_ERR()

backlight_device_register() never returns NULL, it returns error
pointers on error so the check here is wrong.

Acked-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Dan Carpenter 7 лет назад
Родитель
Сommit
74baea4275
1 измененных файлов с 1 добавлено и 1 удалено
  1. 1 1
      drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

+ 1 - 1
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

@@ -1296,7 +1296,7 @@ amdgpu_dm_register_backlight_device(struct amdgpu_display_manager *dm)
 			&amdgpu_dm_backlight_ops,
 			&amdgpu_dm_backlight_ops,
 			&props);
 			&props);
 
 
-	if (NULL == dm->backlight_dev)
+	if (IS_ERR(dm->backlight_dev))
 		DRM_ERROR("DM: Backlight registration failed!\n");
 		DRM_ERROR("DM: Backlight registration failed!\n");
 	else
 	else
 		DRM_DEBUG_DRIVER("DM: Registered Backlight device: %s\n", bl_name);
 		DRM_DEBUG_DRIVER("DM: Registered Backlight device: %s\n", bl_name);