ソースを参照

netfilter: arp_tables: remove redundant check on ret being non-zero

ret is initialized to zero and if it is set to non-zero in the
xt_entry_foreach loop then we exit via the out_free label. Hence
the check for ret being non-zero is redundant and can be removed.

Detected by CoverityScan, CID#1357132 ("Logically Dead Code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Colin Ian King 8 年 前
コミット
74664cf286
1 ファイル変更0 行追加2 行削除
  1. 0 2
      net/ipv4/netfilter/arp_tables.c

+ 0 - 2
net/ipv4/netfilter/arp_tables.c

@@ -562,8 +562,6 @@ static int translate_table(struct xt_table_info *newinfo, void *entry0,
 		    XT_ERROR_TARGET) == 0)
 			++newinfo->stacksize;
 	}
-	if (ret != 0)
-		goto out_free;
 
 	ret = -EINVAL;
 	if (i != repl->num_entries)