Browse Source

tcp: remove useless add operation when init sysctl_max_tw_buckets

cp_hashinfo.ehash_mask is always an odd number, which is set in function
alloc_large_system_hash(). See bellow,
        if (_hash_mask)
                *_hash_mask = (1 << log2qty) - 1; <<< always odd number

Hence the local variable 'cnt' is a even number, as a result of that it is
no difference to do the incrementation here.

Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Yafang Shao 7 years ago
parent
commit
743e481580
1 changed files with 1 additions and 1 deletions
  1. 1 1
      net/ipv4/tcp_ipv4.c

+ 1 - 1
net/ipv4/tcp_ipv4.c

@@ -2549,7 +2549,7 @@ static int __net_init tcp_sk_init(struct net *net)
 	net->ipv4.sysctl_tcp_tw_reuse = 2;
 	net->ipv4.sysctl_tcp_tw_reuse = 2;
 
 
 	cnt = tcp_hashinfo.ehash_mask + 1;
 	cnt = tcp_hashinfo.ehash_mask + 1;
-	net->ipv4.tcp_death_row.sysctl_max_tw_buckets = (cnt + 1) / 2;
+	net->ipv4.tcp_death_row.sysctl_max_tw_buckets = cnt / 2;
 	net->ipv4.tcp_death_row.hashinfo = &tcp_hashinfo;
 	net->ipv4.tcp_death_row.hashinfo = &tcp_hashinfo;
 
 
 	net->ipv4.sysctl_max_syn_backlog = max(128, cnt / 256);
 	net->ipv4.sysctl_max_syn_backlog = max(128, cnt / 256);