Browse Source

[media] anysee: make sure loading modules is const

Make sure that loaded modules are const char strings so we don't
load arbitrary modules in the future, nor allow for format string
leaks in the module request call.

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Kees Cook 10 years ago
parent
commit
7383159f41
1 changed files with 3 additions and 3 deletions
  1. 3 3
      drivers/media/usb/dvb-usb-v2/anysee.c

+ 3 - 3
drivers/media/usb/dvb-usb-v2/anysee.c

@@ -630,8 +630,8 @@ error:
 	return ret;
 	return ret;
 }
 }
 
 
-static int anysee_add_i2c_dev(struct dvb_usb_device *d, char *type, u8 addr,
-		void *platform_data)
+static int anysee_add_i2c_dev(struct dvb_usb_device *d, const char *type,
+		u8 addr, void *platform_data)
 {
 {
 	int ret, num;
 	int ret, num;
 	struct anysee_state *state = d_to_priv(d);
 	struct anysee_state *state = d_to_priv(d);
@@ -659,7 +659,7 @@ static int anysee_add_i2c_dev(struct dvb_usb_device *d, char *type, u8 addr,
 		goto err;
 		goto err;
 	}
 	}
 
 
-	request_module(board_info.type);
+	request_module("%s", board_info.type);
 
 
 	/* register I2C device */
 	/* register I2C device */
 	client = i2c_new_device(adapter, &board_info);
 	client = i2c_new_device(adapter, &board_info);