Jelajahi Sumber

NFS: get module in idmap PipeFS notifier callback

This is bug fix.
Notifier callback is called from SUNRPC module. So before dereferencing NFS
module we have to make sure, that it's alive.

Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Stanislav Kinsbursky 13 tahun lalu
induk
melakukan
71dfc5fa51
1 mengubah file dengan 4 tambahan dan 0 penghapusan
  1. 4 0
      fs/nfs/idmap.c

+ 4 - 0
fs/nfs/idmap.c

@@ -554,12 +554,16 @@ static int rpc_pipefs_event(struct notifier_block *nb, unsigned long event,
 	struct nfs_client *clp;
 	struct nfs_client *clp;
 	int error = 0;
 	int error = 0;
 
 
+	if (!try_module_get(THIS_MODULE))
+		return 0;
+
 	while ((clp = nfs_get_client_for_event(sb->s_fs_info, event))) {
 	while ((clp = nfs_get_client_for_event(sb->s_fs_info, event))) {
 		error = __rpc_pipefs_event(clp, event, sb);
 		error = __rpc_pipefs_event(clp, event, sb);
 		nfs_put_client(clp);
 		nfs_put_client(clp);
 		if (error)
 		if (error)
 			break;
 			break;
 	}
 	}
+	module_put(THIS_MODULE);
 	return error;
 	return error;
 }
 }