瀏覽代碼

net: wireless: ath: ar5523: ar5523: don't print error when allocating urb fails

kmalloc will print enough information in case of failure.

Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Wolfram Sang 9 年之前
父節點
當前提交
71c4c616ec
共有 1 個文件被更改,包括 2 次插入7 次删除
  1. 2 7
      drivers/net/wireless/ath/ar5523/ar5523.c

+ 2 - 7
drivers/net/wireless/ath/ar5523/ar5523.c

@@ -706,10 +706,8 @@ static int ar5523_alloc_rx_bufs(struct ar5523 *ar)
 
 
 		data->ar = ar;
 		data->ar = ar;
 		data->urb = usb_alloc_urb(0, GFP_KERNEL);
 		data->urb = usb_alloc_urb(0, GFP_KERNEL);
-		if (!data->urb) {
-			ar5523_err(ar, "could not allocate rx data urb\n");
+		if (!data->urb)
 			goto err;
 			goto err;
-		}
 		list_add_tail(&data->list, &ar->rx_data_free);
 		list_add_tail(&data->list, &ar->rx_data_free);
 		atomic_inc(&ar->rx_data_free_cnt);
 		atomic_inc(&ar->rx_data_free_cnt);
 	}
 	}
@@ -824,7 +822,6 @@ static void ar5523_tx_work_locked(struct ar5523 *ar)
 
 
 		urb = usb_alloc_urb(0, GFP_KERNEL);
 		urb = usb_alloc_urb(0, GFP_KERNEL);
 		if (!urb) {
 		if (!urb) {
-			ar5523_err(ar, "Failed to allocate TX urb\n");
 			ieee80211_free_txskb(ar->hw, skb);
 			ieee80211_free_txskb(ar->hw, skb);
 			continue;
 			continue;
 		}
 		}
@@ -949,10 +946,8 @@ static int ar5523_alloc_tx_cmd(struct ar5523 *ar)
 	init_completion(&cmd->done);
 	init_completion(&cmd->done);
 
 
 	cmd->urb_tx = usb_alloc_urb(0, GFP_KERNEL);
 	cmd->urb_tx = usb_alloc_urb(0, GFP_KERNEL);
-	if (!cmd->urb_tx) {
-		ar5523_err(ar, "could not allocate urb\n");
+	if (!cmd->urb_tx)
 		return -ENOMEM;
 		return -ENOMEM;
-	}
 	cmd->buf_tx = usb_alloc_coherent(ar->dev, AR5523_MAX_TXCMDSZ,
 	cmd->buf_tx = usb_alloc_coherent(ar->dev, AR5523_MAX_TXCMDSZ,
 					 GFP_KERNEL,
 					 GFP_KERNEL,
 					 &cmd->urb_tx->transfer_dma);
 					 &cmd->urb_tx->transfer_dma);