Browse Source

usb: typec: wcove: fix uninitialized usbc_irq1 and usbc_irq2

Calls to regmap_read may fail with an -EINVAL return without setting
usbc_irq1 and usbc_irq2.  The error handling clean up expects these
to have been set (or zero on a failure) and currently may try to
clear the wrong IRQs if the uninitalized garbage values in usbc_irq1
or usbc_irq2 are non-zero.  The simplest fix is to ensure these
variables are initialized to zero.

Detected by CoverityScan, CID#1457737 ("Uninitialized scalar variable")

Fixes: 3c4fb9f16921 ("usb: typec: wcove: start using tcpm for USB PD support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King 7 years ago
parent
commit
707a123d7a
1 changed files with 2 additions and 2 deletions
  1. 2 2
      drivers/usb/typec/typec_wcove.c

+ 2 - 2
drivers/usb/typec/typec_wcove.c

@@ -441,8 +441,8 @@ static int wcove_read_rx_buffer(struct wcove_typec *wcove, void *msg)
 static irqreturn_t wcove_typec_irq(int irq, void *data)
 static irqreturn_t wcove_typec_irq(int irq, void *data)
 {
 {
 	struct wcove_typec *wcove = data;
 	struct wcove_typec *wcove = data;
-	unsigned int usbc_irq1;
-	unsigned int usbc_irq2;
+	unsigned int usbc_irq1 = 0;
+	unsigned int usbc_irq2 = 0;
 	unsigned int cc1ctrl;
 	unsigned int cc1ctrl;
 	int ret;
 	int ret;