瀏覽代碼

spi/s3c64xx: Put the /CS GPIO into output mode

No call was being made by the GPIO driver to put the GPIO into output
mode meaning that the calls to gpio_set_value() which were being done
were not valid. A similar issue appears to exist with the DT GPIO
requests but as they appear to be being used for pinmux it's less clear
to me that we want to configure them.

Without this fix Cragganmore systems can't talk to their SPI devices.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
Mark Brown 13 年之前
父節點
當前提交
707214d097
共有 1 個文件被更改,包括 2 次插入1 次删除
  1. 2 1
      drivers/spi/spi-s3c64xx.c

+ 2 - 1
drivers/spi/spi-s3c64xx.c

@@ -894,7 +894,8 @@ static int s3c64xx_spi_setup(struct spi_device *spi)
 	}
 	}
 
 
 	if (!spi_get_ctldata(spi)) {
 	if (!spi_get_ctldata(spi)) {
-		err = gpio_request(cs->line, dev_name(&spi->dev));
+		err = gpio_request_one(cs->line, GPIOF_OUT_INIT_HIGH,
+				       dev_name(&spi->dev));
 		if (err) {
 		if (err) {
 			dev_err(&spi->dev,
 			dev_err(&spi->dev,
 				"Failed to get /CS gpio [%d]: %d\n",
 				"Failed to get /CS gpio [%d]: %d\n",