Browse Source

efi: Fix compiler warnings (unused, const, type)

This patch fixes a few compiler warning in the efi code for unused
variable, discarding const qualifier and wrong pointer type:

drivers/firmware/efi/fdt.c|66 col 22| warning: unused variable ‘name’ [-Wunused-variable]
drivers/firmware/efi/efi.c|368 col 3| warning: passing argument 3 of ‘of_get_flat_dt_prop’ from incompatible pointer type [enabled by default]
drivers/firmware/efi/efi.c|368 col 8| warning: assignment discards ‘const’ qualifier from pointer target type [enabled by default]

Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Catalin Marinas 11 years ago
parent
commit
6fb8cc82c0
2 changed files with 4 additions and 4 deletions
  1. 3 3
      drivers/firmware/efi/efi.c
  2. 1 1
      drivers/firmware/efi/fdt.c

+ 3 - 3
drivers/firmware/efi/efi.c

@@ -353,10 +353,10 @@ static int __init fdt_find_uefi_params(unsigned long node, const char *uname,
 				       int depth, void *data)
 				       int depth, void *data)
 {
 {
 	struct param_info *info = data;
 	struct param_info *info = data;
-	void *prop, *dest;
-	unsigned long len;
+	const void *prop;
+	void *dest;
 	u64 val;
 	u64 val;
-	int i;
+	int i, len;
 
 
 	if (depth != 1 ||
 	if (depth != 1 ||
 	    (strcmp(uname, "chosen") != 0 && strcmp(uname, "chosen@0") != 0))
 	    (strcmp(uname, "chosen") != 0 && strcmp(uname, "chosen@0") != 0))

+ 1 - 1
drivers/firmware/efi/fdt.c

@@ -63,7 +63,7 @@ static efi_status_t update_fdt(efi_system_table_t *sys_table, void *orig_fdt,
 	 */
 	 */
 	prev = 0;
 	prev = 0;
 	for (;;) {
 	for (;;) {
-		const char *type, *name;
+		const char *type;
 		int len;
 		int len;
 
 
 		node = fdt_next_node(fdt, prev, NULL);
 		node = fdt_next_node(fdt, prev, NULL);