Просмотр исходного кода

fm10k: fix memory leak

This was detected by Coverity.
The function skb_cow_head leaves skb alone on failure, so caller needs
to free.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
stephen hemminger 9 лет назад
Родитель
Сommit
6f97532ef0
1 измененных файлов с 3 добавлено и 1 удалено
  1. 3 1
      drivers/net/ethernet/intel/fm10k/fm10k_netdev.c

+ 3 - 1
drivers/net/ethernet/intel/fm10k/fm10k_netdev.c

@@ -627,8 +627,10 @@ static netdev_tx_t fm10k_xmit_frame(struct sk_buff *skb, struct net_device *dev)
 
 		/* verify the skb head is not shared */
 		err = skb_cow_head(skb, 0);
-		if (err)
+		if (err) {
+			dev_kfree_skb(skb);
 			return NETDEV_TX_OK;
+		}
 
 		/* locate vlan header */
 		vhdr = (struct vlan_hdr *)(skb->data + ETH_HLEN);