瀏覽代碼

irqchip/gic-v3-its: Fix VPE activate callback return value

its_vpe_irq_domain_activate should always return 0. Really. There
is not a single case why it wouldn't.  So this "return true;" is
really a copy/paste issue that got revealed now that we actually
check the return value of the activate method.

Brown paper bag day.

Fixes: 2247e1bf7063 ("irqchip/gic-v3-its: Limit scope of VPE mapping to be per ITS")
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Marc Zyngier 7 年之前
父節點
當前提交
6ef930f20c
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/irqchip/irq-gic-v3-its.c

+ 1 - 1
drivers/irqchip/irq-gic-v3-its.c

@@ -2802,7 +2802,7 @@ static int its_vpe_irq_domain_activate(struct irq_domain *domain,
 
 
 	/* If we use the list map, we issue VMAPP on demand... */
 	/* If we use the list map, we issue VMAPP on demand... */
 	if (its_list_map)
 	if (its_list_map)
-		return true;
+		return 0;
 
 
 	/* Map the VPE to the first possible CPU */
 	/* Map the VPE to the first possible CPU */
 	vpe->col_idx = cpumask_first(cpu_online_mask);
 	vpe->col_idx = cpumask_first(cpu_online_mask);