Эх сурвалжийг харах

bonding: Return correct error code

The return value of kzalloc on failure of allocation of memory should
be -ENOMEM and not -1.

Found using Coccinelle. A simplified version of the semantic patch
used is:

//<smpl>
@@
expression *e;
@@

e = kzalloc(...);
if (e == NULL) {
...
return
- -1
+ -ENOMEM
;
}
//</smpl>

The single call site only checks that the return value is not 0,
hence no change is required at the call site.

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Amitoj Kaur Chawla 9 жил өмнө
parent
commit
6d9b6f424d

+ 1 - 1
drivers/net/bonding/bond_alb.c

@@ -159,7 +159,7 @@ static int tlb_initialize(struct bonding *bond)
 
 
 	new_hashtbl = kzalloc(size, GFP_KERNEL);
 	new_hashtbl = kzalloc(size, GFP_KERNEL);
 	if (!new_hashtbl)
 	if (!new_hashtbl)
-		return -1;
+		return -ENOMEM;
 
 
 	spin_lock_bh(&bond->mode_lock);
 	spin_lock_bh(&bond->mode_lock);