浏览代码

usb: ehci/ohci-exynos: Fix of_node_put() for child when getting PHYs

On enabling CONFIG_OF_SELFTEST which enables CONFIG_OF_DYNAMIC,
we found out that while getting PHYs for the controller we were
doing an extra of_node_put on the child node in our routines -
exynos_e/ohci_get_phy().
This child is however already put by of_get_next_available_child()
which does a of_node_put() on the "prev" node. So there's no point
in putting the same node again in our routine.

Reported-by: Daniel Drake <drake@endlessm.com>
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vivek Gautam 11 年之前
父节点
当前提交
6d40500ac9
共有 2 个文件被更改,包括 0 次插入2 次删除
  1. 0 1
      drivers/usb/host/ehci-exynos.c
  2. 0 1
      drivers/usb/host/ohci-exynos.c

+ 0 - 1
drivers/usb/host/ehci-exynos.c

@@ -74,7 +74,6 @@ static int exynos_ehci_get_phy(struct device *dev,
 
 
 		phy = devm_of_phy_get(dev, child, NULL);
 		phy = devm_of_phy_get(dev, child, NULL);
 		exynos_ehci->phy[phy_number] = phy;
 		exynos_ehci->phy[phy_number] = phy;
-		of_node_put(child);
 		if (IS_ERR(phy)) {
 		if (IS_ERR(phy)) {
 			ret = PTR_ERR(phy);
 			ret = PTR_ERR(phy);
 			if (ret == -EPROBE_DEFER) {
 			if (ret == -EPROBE_DEFER) {

+ 0 - 1
drivers/usb/host/ohci-exynos.c

@@ -63,7 +63,6 @@ static int exynos_ohci_get_phy(struct device *dev,
 
 
 		phy = devm_of_phy_get(dev, child, NULL);
 		phy = devm_of_phy_get(dev, child, NULL);
 		exynos_ohci->phy[phy_number] = phy;
 		exynos_ohci->phy[phy_number] = phy;
-		of_node_put(child);
 		if (IS_ERR(phy)) {
 		if (IS_ERR(phy)) {
 			ret = PTR_ERR(phy);
 			ret = PTR_ERR(phy);
 			if (ret == -EPROBE_DEFER) {
 			if (ret == -EPROBE_DEFER) {