Selaa lähdekoodia

[media] pwc: Use kmemdup rather than duplicating its implementation

The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Thomas Meyer 13 vuotta sitten
vanhempi
commit
6d00c9aa2b
1 muutettua tiedostoa jossa 1 lisäystä ja 2 poistoa
  1. 1 2
      drivers/media/video/pwc/pwc-ctrl.c

+ 1 - 2
drivers/media/video/pwc/pwc-ctrl.c

@@ -113,10 +113,9 @@ static int _send_control_msg(struct pwc_device *pdev,
 	void *kbuf = NULL;
 	void *kbuf = NULL;
 
 
 	if (buflen) {
 	if (buflen) {
-		kbuf = kmalloc(buflen, GFP_KERNEL); /* not allowed on stack */
+		kbuf = kmemdup(buf, buflen, GFP_KERNEL); /* not allowed on stack */
 		if (kbuf == NULL)
 		if (kbuf == NULL)
 			return -ENOMEM;
 			return -ENOMEM;
-		memcpy(kbuf, buf, buflen);
 	}
 	}
 
 
 	rc = usb_control_msg(pdev->udev, usb_sndctrlpipe(pdev->udev, 0),
 	rc = usb_control_msg(pdev->udev, usb_sndctrlpipe(pdev->udev, 0),