浏览代码

firewire: fix failure path in ohci_enable_phys_dma

"goto out" happens with the lock taken.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Stefan Richter 18 年之前
父节点
当前提交
6cad95fe97
共有 1 个文件被更改,包括 1 次插入3 次删除
  1. 1 3
      drivers/firewire/fw-ohci.c

+ 1 - 3
drivers/firewire/fw-ohci.c

@@ -850,10 +850,8 @@ ohci_enable_phys_dma(struct fw_card *card, int node_id, int generation)
 			  1 << (node_id - 32));
 			  1 << (node_id - 32));
 	}
 	}
 	flush_writes(ohci);
 	flush_writes(ohci);
-
-	spin_unlock_irqrestore(&ohci->lock, flags);
-
  out:
  out:
+	spin_unlock_irqrestore(&ohci->lock, flags);
 	return retval;
 	return retval;
 }
 }