Эх сурвалжийг харах

Btrfs: don't leak reloc root nodes on error

We don't track the reloc roots in any sort of normal way, so the only way the
root/commit_root nodes get free'd is if the relocation finishes successfully and
the reloc root is deleted.  Fix this by free'ing them in free_reloc_roots.
Thanks,

Signed-off-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Josef Bacik 9 жил өмнө
parent
commit
6bdf131fac
1 өөрчлөгдсөн 4 нэмэгдсэн , 0 устгасан
  1. 4 0
      fs/btrfs/relocation.c

+ 4 - 0
fs/btrfs/relocation.c

@@ -2357,6 +2357,10 @@ void free_reloc_roots(struct list_head *list)
 	while (!list_empty(list)) {
 		reloc_root = list_entry(list->next, struct btrfs_root,
 					root_list);
+		free_extent_buffer(reloc_root->node);
+		free_extent_buffer(reloc_root->commit_root);
+		reloc_root->node = NULL;
+		reloc_root->commit_root = NULL;
 		__del_reloc_root(reloc_root);
 	}
 }