Przeglądaj źródła

usb: gadget: f_uac1: eliminate abuse of ep->driver data

Since ep->driver_data is not used for endpoint claiming, neither for
enabled/disabled state storing, we can reduce number of places where
we read or modify it's value, as now it has no particular meaning for
function or framework logic.

In case of f_uac1, ep->driver_data was used only for endpoint claiming
and marking endpoints as enabled, so we can simplify code by reducing
it.

Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Robert Baldyga 10 lat temu
rodzic
commit
6ae6e1a241
1 zmienionych plików z 0 dodań i 4 usunięć
  1. 0 4
      drivers/usb/gadget/function/f_uac1.c

+ 0 - 4
drivers/usb/gadget/function/f_uac1.c

@@ -593,7 +593,6 @@ static int f_audio_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
 				return err;
 				return err;
 
 
 			usb_ep_enable(out_ep);
 			usb_ep_enable(out_ep);
-			out_ep->driver_data = audio;
 			audio->copy_buf = f_audio_buffer_alloc(audio_buf_size);
 			audio->copy_buf = f_audio_buffer_alloc(audio_buf_size);
 			if (IS_ERR(audio->copy_buf))
 			if (IS_ERR(audio->copy_buf))
 				return -ENOMEM;
 				return -ENOMEM;
@@ -718,7 +717,6 @@ f_audio_bind(struct usb_configuration *c, struct usb_function *f)
 		goto fail;
 		goto fail;
 	audio->out_ep = ep;
 	audio->out_ep = ep;
 	audio->out_ep->desc = &as_out_ep_desc;
 	audio->out_ep->desc = &as_out_ep_desc;
-	ep->driver_data = cdev;	/* claim */
 
 
 	status = -ENOMEM;
 	status = -ENOMEM;
 
 
@@ -730,8 +728,6 @@ f_audio_bind(struct usb_configuration *c, struct usb_function *f)
 
 
 fail:
 fail:
 	gaudio_cleanup(&audio->card);
 	gaudio_cleanup(&audio->card);
-	if (ep)
-		ep->driver_data = NULL;
 	return status;
 	return status;
 }
 }