Browse Source

gpio: sa1100: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Linus Walleij 9 years ago
parent
commit
6a681b6147
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/gpio/gpio-sa1100.c

+ 1 - 1
drivers/gpio/gpio-sa1100.c

@@ -17,7 +17,7 @@
 
 
 static int sa1100_gpio_get(struct gpio_chip *chip, unsigned offset)
 static int sa1100_gpio_get(struct gpio_chip *chip, unsigned offset)
 {
 {
-	return GPLR & GPIO_GPIO(offset);
+	return !!(GPLR & GPIO_GPIO(offset));
 }
 }
 
 
 static void sa1100_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
 static void sa1100_gpio_set(struct gpio_chip *chip, unsigned offset, int value)