Browse Source

pinctrl: qcom: spmi-mpp: Fix err handling of pmic_mpp_set_mux

'ret' should be returned while pmic_mpp_write_mode_ctl fails.

Fixes: 0e948042c420 ("pinctrl: qcom: spmi-mpp: Implement support for sink mode")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
YueHaibing 7 years ago
parent
commit
69f8455f6c
1 changed files with 2 additions and 0 deletions
  1. 2 0
      drivers/pinctrl/qcom/pinctrl-spmi-mpp.c

+ 2 - 0
drivers/pinctrl/qcom/pinctrl-spmi-mpp.c

@@ -319,6 +319,8 @@ static int pmic_mpp_set_mux(struct pinctrl_dev *pctldev, unsigned function,
 	pad->function = function;
 
 	ret = pmic_mpp_write_mode_ctl(state, pad);
+	if (ret < 0)
+		return ret;
 
 	val = pad->is_enabled << PMIC_MPP_REG_MASTER_EN_SHIFT;