Browse Source

drm/radeon: check buffer relocation offset

Signed-off-by: Leo Liu <leo.liu@amd.com>
Signed-off-by: Christian König <christian.koenig@amd.com>
Cc: stable@vger.kernel.org
Leo Liu 11 years ago
parent
commit
695daf1a8e
1 changed files with 4 additions and 0 deletions
  1. 4 0
      drivers/gpu/drm/radeon/radeon_uvd.c

+ 4 - 0
drivers/gpu/drm/radeon/radeon_uvd.c

@@ -465,6 +465,10 @@ static int radeon_uvd_cs_reloc(struct radeon_cs_parser *p,
 	cmd = radeon_get_ib_value(p, p->idx) >> 1;
 	cmd = radeon_get_ib_value(p, p->idx) >> 1;
 
 
 	if (cmd < 0x4) {
 	if (cmd < 0x4) {
+		if (end <= start) {
+			DRM_ERROR("invalid reloc offset %X!\n", offset);
+			return -EINVAL;
+		}
 		if ((end - start) < buf_sizes[cmd]) {
 		if ((end - start) < buf_sizes[cmd]) {
 			DRM_ERROR("buffer (%d) to small (%d / %d)!\n", cmd,
 			DRM_ERROR("buffer (%d) to small (%d / %d)!\n", cmd,
 				  (unsigned)(end - start), buf_sizes[cmd]);
 				  (unsigned)(end - start), buf_sizes[cmd]);