浏览代码

torture: Avoid format string leak to thead name

Since the torture-test thread creation interface does not include
format string arguments, this commit makes sure the name can never be
accidentally processed as a format string.

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Kees Cook 11 年之前
父节点
当前提交
6945915e7f
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      kernel/torture.c

+ 1 - 1
kernel/torture.c

@@ -708,7 +708,7 @@ int _torture_create_kthread(int (*fn)(void *arg), void *arg, char *s, char *m,
 	int ret = 0;
 	int ret = 0;
 
 
 	VERBOSE_TOROUT_STRING(m);
 	VERBOSE_TOROUT_STRING(m);
-	*tp = kthread_run(fn, arg, s);
+	*tp = kthread_run(fn, arg, "%s", s);
 	if (IS_ERR(*tp)) {
 	if (IS_ERR(*tp)) {
 		ret = PTR_ERR(*tp);
 		ret = PTR_ERR(*tp);
 		VERBOSE_TOROUT_ERRSTRING(f);
 		VERBOSE_TOROUT_ERRSTRING(f);