瀏覽代碼

net/mlx5e: IPoIB, Fix error handling in mlx5_rdma_netdev_alloc()

The labels were out of order, so it either could result in an Oops or a
leak.

Fixes: 48935bbb7ae8 ("net/mlx5e: IPoIB, Add netdevice profile skeleton")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Dan Carpenter 8 年之前
父節點
當前提交
6905e5a5c8
共有 1 個文件被更改,包括 3 次插入2 次删除
  1. 3 2
      drivers/net/ethernet/mellanox/mlx5/core/ipoib.c

+ 3 - 2
drivers/net/ethernet/mellanox/mlx5/core/ipoib.c

@@ -471,10 +471,11 @@ struct net_device *mlx5_rdma_netdev_alloc(struct mlx5_core_dev *mdev,
 	 */
 	 */
 	return netdev;
 	return netdev;
 
 
-free_mdev_resources:
-	mlx5e_destroy_mdev_resources(mdev);
 err_free_netdev:
 err_free_netdev:
 	free_netdev(netdev);
 	free_netdev(netdev);
+free_mdev_resources:
+	mlx5e_destroy_mdev_resources(mdev);
+
 	return NULL;
 	return NULL;
 }
 }
 EXPORT_SYMBOL(mlx5_rdma_netdev_alloc);
 EXPORT_SYMBOL(mlx5_rdma_netdev_alloc);