Selaa lähdekoodia

video: of: display_timing: delete unneeded test before of_node_put

Of_node_put supports NULL as its argument, so the initial test is not
necessary.  Furthermore, native_mode cannot be NULL at this point.

Suggested by Uwe Kleine-König.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
@@

-if (e)
   of_node_put(e);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Julia Lawall 11 vuotta sitten
vanhempi
commit
68ecfe2fe2
1 muutettua tiedostoa jossa 1 lisäystä ja 2 poistoa
  1. 1 2
      drivers/video/of_display_timing.c

+ 1 - 2
drivers/video/of_display_timing.c

@@ -233,8 +233,7 @@ struct display_timings *of_get_display_timings(struct device_node *np)
 	return disp;
 
 timingfail:
-	if (native_mode)
-		of_node_put(native_mode);
+	of_node_put(native_mode);
 	display_timings_release(disp);
 entryfail:
 	kfree(disp);