Browse Source

rtc: rv8803: fix handling return value of i2c_smbus_read_byte_data

The function can return negative values, so its result should
be assigned to signed variable.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Andrzej Hajda 9 years ago
parent
commit
68c85f2916
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/rtc/rtc-rv8803.c

+ 1 - 1
drivers/rtc/rtc-rv8803.c

@@ -61,7 +61,7 @@ static irqreturn_t rv8803_handle_irq(int irq, void *dev_id)
 	struct i2c_client *client = dev_id;
 	struct i2c_client *client = dev_id;
 	struct rv8803_data *rv8803 = i2c_get_clientdata(client);
 	struct rv8803_data *rv8803 = i2c_get_clientdata(client);
 	unsigned long events = 0;
 	unsigned long events = 0;
-	u8 flags;
+	int flags;
 
 
 	spin_lock(&rv8803->flags_lock);
 	spin_lock(&rv8803->flags_lock);