Browse Source

[media] coda: reset CODA960 hardware after sequence end

On i.MX6, sometimes after decoding a stream, encoding will produce macroblock
errors caused by missing 8-byte sequences in the output stream. Until the cause
for this is found, reset the hardware after sequence end, which seems to help.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Philipp Zabel 10 years ago
parent
commit
68aa7ee15c
1 changed files with 8 additions and 0 deletions
  1. 8 0
      drivers/media/platform/coda/coda-bit.c

+ 8 - 0
drivers/media/platform/coda/coda-bit.c

@@ -1347,6 +1347,14 @@ static void coda_seq_end_work(struct work_struct *work)
 			 "CODA_COMMAND_SEQ_END failed\n");
 			 "CODA_COMMAND_SEQ_END failed\n");
 	}
 	}
 
 
+	/*
+	 * FIXME: Sometimes h.264 encoding fails with 8-byte sequences missing
+	 * from the output stream after the h.264 decoder has run. Resetting the
+	 * hardware after the decoder has finished seems to help.
+	 */
+	if (dev->devtype->product == CODA_960)
+		coda_hw_reset(ctx);
+
 	kfifo_init(&ctx->bitstream_fifo,
 	kfifo_init(&ctx->bitstream_fifo,
 		ctx->bitstream.vaddr, ctx->bitstream.size);
 		ctx->bitstream.vaddr, ctx->bitstream.size);